Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump lerna to 7.0.2, add @lerna/legacy-package-management #3926

Merged

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

Currently, builds are failing as lerna@6.6.2 depends on rimraf@4.4.1 but @lerna/legacy-package-management@7.0.2 used by it does not, which causes an older version rimraf@3.0.2 to be used.

The next version, @lerna/legacy-package-management@7.0.2 fixes this, but was published with lerna@7.0.2, which does not install the former package automatically to support lerna bootstrap, therefore @lerna/legacy-package-management@7.0.2 it needs to be added as a devDependency.

Fixes #3894
Fixes #3925
Supersedes #3881

Short description of the changes

This PR bumps all lerna dependencies to 7.0.2 and adds @lerna/legacy-package-management@7.0.2 as a devDependency in the top-level package.json

Type of change

  • Bug fix
  • Internal

How Has This Been Tested?

  • ran npm install locally and verified that rimraf is at the correct version
  • Verified that lerna scripts are still working

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #3926 (2d2ed37) into main (5bee444) will not change coverage.
The diff coverage is n/a.

❗ Current head 2d2ed37 differs from pull request most recent head c881e37. Consider uploading reports for the commit c881e37 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3926   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files         297      297           
  Lines        8836     8836           
  Branches     1814     1814           
=======================================
  Hits         8208     8208           
  Misses        628      628           

see 2 files with indirect coverage changes

@legendecas
Copy link
Member

NB: It's @lerna/legacy-package-management v6.6.2 that didn't declare rimraf as it's dependency.

Thank you for figuring this out! I'm going to merge this to unblock other PRs.

@legendecas legendecas merged commit 67d4b80 into open-telemetry:main Jun 20, 2023
pichlermarc added a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Jun 26, 2023
@legendecas legendecas mentioned this pull request Nov 1, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants